-
-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish distributions to TestPyPI on each day #2220
Publish distributions to TestPyPI on each day #2220
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2220 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 124 124
Lines 10240 10241 +1
=======================================
+ Hits 9441 9442 +1
Misses 799 799
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. More frequent upload to TestPyPI will prevent configuration error like this one.
I wonder if we can upload the packages with the same names multiple times. I think the duplicated package was refuled by PyPI.
You are right. From here, we cannot re-upload the same version to PyPI and it is the same for TestPyPI from here. I think we have to create a different branch changing the version dependent on the commit hash (if the trigger is the master push). |
@toshihikoyanase The upload on each master push seems to be impossible since the version name should be different for each upload and the version name cannot include the commit hash according to PEP440. I have changed the trigger to upload TestPyPI each weekday. PTAL. |
I confirmed the TestPyPI upload succeeded not by the scheduled event but by the push event. See here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This change enables users to try the latest Optuna easily in addition to preventing configuration errors of the CI. Thank you.
I'll merge this PR after we resolve #2220 (review). |
@toshihikoyanase @not522 Thanks for your careful reviews! PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your update. LGTM again.
LGTM, please merge it. |
Thanks! |
Depends on #2238.
Motivation
Currently, we publish distributions to PyPI and TestPyPI at the same time when the release, so we cannot detect any error on publishing to PyPI beforehand.
This PR proposes to publish to TestPyPI on each master push. It is a room of discussion for the trigger of the publish.I have changed the uploads to be done every weekday. See #2220 (comment).