Fixes namedtuple type name
#2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The best practice is to match `typename` with variable name. For example, `mypy` reports any other usages as errors: python/mypy#11206 (comment)
|
@toshihikoyanase , @keisuke-umezawa do you have time to review this change? |
toshihikoyanase
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Thank you for your PR! It will prevent future CI failure. LGTM!
- The official Python document also sets the same class name to the
typenameargument, and - we don't have a particular reason to add
_to thetypenames.
keisuke-umezawa
added
the
code-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The best practice is to match
typenamewith variable name.For example,
mypyreports any other usages as errors: python/mypy#11206 (comment)