Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_rank marker lines #4602

Merged
merged 2 commits into from
Apr 17, 2023
Merged

plot_rank marker lines #4602

merged 2 commits into from
Apr 17, 2023

Conversation

hvy
Copy link
Member

@hvy hvy commented Apr 12, 2023

Motivation

Depends on #4427.

Fixes part of comment in #4427 (review) to add marker lines.

Description of the changes

Adds gray borders/lines to plot_rank scatter markers.

@hvy hvy added enhancement Change that does not break compatibility and not affect public interfaces, but improves performance. optuna.visualization Related to the `optuna.visualization` submodule. This is automatically labeled by github-actions. labels Apr 12, 2023
@hvy hvy requested review from contramundum53 and removed request for contramundum53 April 12, 2023 03:06
Copy link
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your PR!

@toshihikoyanase
Copy link
Member

@cross32768 Could you review this PR, please? I guess it is related to #4541.

Copy link
Contributor

@cross32768 cross32768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cross32768 cross32768 merged commit f14b220 into optuna:master Apr 17, 2023
@hvy hvy deleted the plot-rank-marker-line branch April 18, 2023 04:34
@toshihikoyanase toshihikoyanase added this to the v3.2.0 milestone Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Change that does not break compatibility and not affect public interfaces, but improves performance. optuna.visualization Related to the `optuna.visualization` submodule. This is automatically labeled by github-actions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants