Handle deprecated argument early_stopping_rounds
#4752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
optuna.integration
|
This pull request has not seen any recent activity. |
|
This pull request has not seen any recent activity. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #4752 +/- ##
=======================================
Coverage 90.68% 90.69%
=======================================
Files 195 195
Lines 14598 14602 +4
=======================================
+ Hits 13238 13243 +5
+ Misses 1360 1359 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
not522
added
the
code-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The argument
early_stopping_roundsis deprecated in microsoft/LightGBM#4574 and has been already removed in the latest version by microsoft/LightGBM#4908. Our integration uses this argument and currently warned in theTest(integration)as follows.https://github.com/optuna/optuna/actions/runs/5274281893/jobs/9538592552?pr=4746#step:10:167
This PR resolves the warnings while preserving backward compatibility with
LightGBM<4.0.0.Description of the changes
Generate a callback
early_stopping()according to the givenearly_stopping_roundsand pass toLightGBMside. Note thatearly_stopping()is added in the very early stage (microsoft/LightGBM#131) and therefore this change does not break backward compatibility at least with documented version (LightGBM >=v3.2.1).