Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset_learning_rate->reset_parameter #131

Merged
merged 4 commits into from
Dec 18, 2016
Merged

reset_learning_rate->reset_parameter #131

merged 4 commits into from
Dec 18, 2016

Conversation

wxchan
Copy link
Contributor

@wxchan wxchan commented Dec 18, 2016

refer to #129

@guolinke I test some other parameters, it is indeed also not efficient.

@msftclas
Copy link

Hi @wxchan, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@wxchan
Copy link
Contributor Author

wxchan commented Dec 18, 2016

@guolinke lambdarank task causes segfault, it should be some bug. Try following examples:

def test_lambdarank():
    from sklearn.datasets import load_svmlight_file
    X_train, y_train = load_svmlight_file('../../examples/lambdarank/rank.train')
    X_test, y_test = load_svmlight_file('../../examples/lambdarank/rank.test')
    q_train = np.loadtxt('../../examples/lambdarank/rank.train.query')
    q_test= np.loadtxt('../../examples/lambdarank/rank.test.query')
    lgb_model = lgb.LGBMRanker().fit(X_train, y_train, group=q_train, eval_at=[1])
    preds = lgb_model.predict(X_test)

@guolinke
Copy link
Collaborator

@wxchan fixed, you can check again, and add it to the test.

I will optimize the reset parameter logic to make it faster.

@guolinke guolinke merged commit 7a81f7b into microsoft:master Dec 18, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants