Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shap #4791

Merged
merged 15 commits into from
Aug 14, 2023
Merged

Remove shap #4791

merged 15 commits into from
Aug 14, 2023

Conversation

Alnusjaponica
Copy link
Collaborator

Motivation

Progress #4484 and #4789.

Description of the changes

Move ShapleyImportanceEvaluator, related test and docs.

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Jul 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023 •
edited

Codecov Report

Merging #4791 (76ba752) into master (55ed020) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #4791      +/-   ##
==========================================
- Coverage   89.52%   89.49%   -0.04%     
==========================================
  Files         197      197              
  Lines       14676    14632      -44     
==========================================
- Hits        13139    13095      -44     
  Misses       1537     1537
Files Changed Coverage Δ
optuna/integration/shap.py 0.00% <0.00%> (-100.00%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Alnusjaponica Alnusjaponica marked this pull request as ready for review July 6, 2023 10:10
@c-bata c-bata assigned eukaryo and contramundum53 and unassigned eukaryo Jul 7, 2023
@c-bata
Copy link
Member

c-bata commented Jul 7, 2023

@eukaryo @contramundum53 Could you review this PR?

@contramundum53
Copy link
Member

I'll review this PR after optuna/optuna-integration#32 is merged.

@Alnusjaponica Alnusjaponica mentioned this pull request Jul 12, 2023
Closed
5 tasks
@not522 not522 mentioned this pull request Jul 13, 2023
Closed
@github-actions
Copy link
Contributor

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Jul 16, 2023
@github-actions github-actions bot removed the stale Exempt from stale bot labeling. label Jul 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Aug 6, 2023
@Alnusjaponica
Copy link
Collaborator Author

@contramundum53
This is a kind reminder that I am waiting for your review.

@github-actions github-actions bot removed the stale Exempt from stale bot labeling. label Aug 7, 2023
@c-bata c-bata added this to the v3.4.0 milestone Aug 10, 2023
@c-bata c-bata added the code-fix Change that does not change the behavior, such as code refactoring. label Aug 10, 2023
@c-bata
Copy link
Member

c-bata commented Aug 10, 2023

Let me reassign reviewers. @HideakiImamura Could you review this PR if you have time?

c-bata
c-bata approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-bata c-bata removed their assignment Aug 10, 2023
HideakiImamura
HideakiImamura approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura merged commit 59c6607 into optuna:master Aug 14, 2023
31 checks passed
@Alnusjaponica Alnusjaponica deleted the remove-shap branch August 14, 2023 06:22
@Alnusjaponica Alnusjaponica mentioned this pull request Nov 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-bata c-bata c-bata approved these changes

@HideakiImamura HideakiImamura HideakiImamura approved these changes

Assignees

@HideakiImamura HideakiImamura

Labels
code-fix Change that does not change the behavior, such as code refactoring. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Alnusjaponica @codecov-commenter @c-bata @contramundum53 @HideakiImamura @eukaryo