Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up workflow file #5122

Merged
merged 3 commits into from Nov 21, 2023
Merged

Conversation

Alnusjaponica
Copy link
Collaborator

Motivation

Follow up #4968 and #4791

Description of the changes

Remove unnecessary comments and spaces

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17b5115) 89.31% compared to head (2223bd6) 89.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5122   +/-   ##
=======================================
  Coverage   89.31%   89.31%           
=======================================
  Files         205      205           
  Lines       15188    15188           
=======================================
  Hits        13565    13565           
  Misses       1623     1623           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nabenabe0928 nabenabe0928 requested review from eukaryo and removed request for eukaryo November 20, 2023 09:05
Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
LGTM")

@nabenabe0928 nabenabe0928 removed their assignment Nov 21, 2023
Copy link
Collaborator

@eukaryo eukaryo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eukaryo eukaryo added this to the v3.5.0 milestone Nov 21, 2023
@eukaryo eukaryo merged commit bed986a into optuna:master Nov 21, 2023
35 checks passed
@Alnusjaponica Alnusjaponica deleted the remove-resolved-todo branch November 21, 2023 11:27
@not522 not522 added the code-fix Change that does not change the behavior, such as code refactoring. label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants