Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact docs #4855

Merged
merged 12 commits into from
Aug 3, 2023
Merged

Artifact docs #4855

merged 12 commits into from
Aug 3, 2023

Conversation

Alnusjaponica
Copy link
Collaborator

Motivation

References #4843

Description of the changes

Do first three tasks in #4843: Update .rst files and add example code to docstrings.

@c-bata c-bata self-assigned this Aug 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4855 (2867b04) into master (82f3675) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #4855   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files         200      200           
  Lines       14771    14771           
=======================================
  Hits        13240    13240           
  Misses       1531     1531           
Files Changed Coverage Δ
optuna/artifacts/_boto3.py 88.09% <ø> (ø)
optuna/artifacts/_filesystem.py 90.90% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Alnusjaponica Alnusjaponica marked this pull request as ready for review August 3, 2023 05:19
@c-bata
Copy link
Member

c-bata commented Aug 3, 2023

@HideakiImamura Could you review this PR?

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request. I left some comments.

optuna/artifacts/_boto3.py Outdated Show resolved Hide resolved
optuna/artifacts/_boto3.py Outdated Show resolved Hide resolved
docs/source/reference/artifacts.rst Outdated Show resolved Hide resolved
@c-bata c-bata added this to the v3.3.0 milestone Aug 3, 2023
Alnusjaponica and others added 4 commits August 3, 2023 15:58
Co-authored-by: c-bata <c-bata@users.noreply.github.com>
Co-authored-by: c-bata <c-bata@users.noreply.github.com>
Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after passing CI!

@c-bata c-bata removed their assignment Aug 3, 2023
@c-bata c-bata added the document Documentation related. label Aug 3, 2023
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura merged commit f827582 into optuna:master Aug 3, 2023
30 checks passed
@Alnusjaponica Alnusjaponica deleted the artifact-docs branch August 11, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants