New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate LightGBM integration #5249
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5249 +/- ##
==========================================
- Coverage 89.83% 89.31% -0.52%
==========================================
Files 213 206 -7
Lines 13707 13020 -687
==========================================
- Hits 12313 11629 -684
+ Misses 1394 1391 -3 ☔ View full report in Codecov by Sentry. |
dc15fe5
to
9956f66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, I found a critical problem we need to address, please take a close look!
@nabenabe0928 While you have already reviewed this PR, let me assign you as a reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the modification!
I confirmed that the changes work perfectly!
$ pip install git+https://github.com/optuna/optuna-integration@main
$ pip install lightgbm
$ python -c "from optuna.integration.lightgbm import Dataset, train"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I have several comments. PTAL.
tutorial/10_key_features/003_efficient_optimization_algorithms.py
Outdated
Show resolved
Hide resolved
tutorial/10_key_features/003_efficient_optimization_algorithms.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Hideaki Imamura <38826298+HideakiImamura@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Motivation
Progress #4484.
Description of the changes