Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate LightGBM integration #5249

Merged
merged 22 commits into from Feb 15, 2024
Merged

Conversation

y0z
Copy link
Member

@y0z y0z commented Feb 14, 2024

Motivation

Progress #4484.

Description of the changes

@y0z y0z changed the title Migrate LightGBM integration. Migrate LightGBM integration Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (e905252) 89.83% compared to head (591a0ed) 89.31%.
Report is 5 commits behind head on master.

Files Patch % Lines
optuna/integration/lightgbm.py 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5249      +/-   ##
==========================================
- Coverage   89.83%   89.31%   -0.52%     
==========================================
  Files         213      206       -7     
  Lines       13707    13020     -687     
==========================================
- Hits        12313    11629     -684     
+ Misses       1394     1391       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, I found a critical problem we need to address, please take a close look!

tutorial/20_recipes/008_specify_params.py Outdated Show resolved Hide resolved
tutorial/20_recipes/008_specify_params.py Outdated Show resolved Hide resolved
tutorial/10_key_features/005_visualization.py Outdated Show resolved Hide resolved
tutorial/10_key_features/005_visualization.py Outdated Show resolved Hide resolved
optuna/integration/lightgbm.py Outdated Show resolved Hide resolved
@HideakiImamura
Copy link
Member

@nabenabe0928 While you have already reviewed this PR, let me assign you as a reviewer.

Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the modification!
I confirmed that the changes work perfectly!

$ pip install git+https://github.com/optuna/optuna-integration@main
$ pip install lightgbm
$ python -c "from optuna.integration.lightgbm import Dataset, train"

@nabenabe0928 nabenabe0928 removed their assignment Feb 15, 2024
@nabenabe0928 nabenabe0928 added the compatibility Change that breaks compatibility. label Feb 15, 2024
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have several comments. PTAL.

tutorial/10_key_features/005_visualization.py Outdated Show resolved Hide resolved
tutorial/20_recipes/008_specify_params.py Outdated Show resolved Hide resolved
y0z and others added 2 commits February 15, 2024 15:04
Co-authored-by: Hideaki Imamura <38826298+HideakiImamura@users.noreply.github.com>
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura merged commit 32f5ce9 into optuna:master Feb 15, 2024
28 checks passed
@HideakiImamura HideakiImamura added this to the v3.6.0 milestone Feb 15, 2024
@y0z y0z deleted the feature/migrate-lightgbm branch February 16, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Change that breaks compatibility.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants