Replace lightgbm with PyTorch-based example to remove lightgbm dependency in visualization tutorial #5257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m dependency. The example of pytorch script comes from the multi-objective tutorial page: Multi-objective Optimization with Optuna
|
@y0z Could you review this PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5257 +/- ##
==========================================
+ Coverage 89.23% 89.38% +0.15%
==========================================
Files 206 209 +3
Lines 12944 13119 +175
==========================================
+ Hits 11550 11727 +177
+ Misses 1394 1392 -2 ☔ View full report in Codecov by Sentry. |
y0z
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Thank you for your contribution.
LGTM!
NIT: Although coincidentally, in the example, the first trial achieves the best accuracy. To better demonstrate the optimization history plot, another random seed involving best-value updates might be preferable.
|
@y0z Thank you for your review and suggestion. How about this plot that I used a different random seed?
|
|
Thank you for your update! |
nabenabe0928
approved these changes
Feb 20, 2024
nzw0301
deleted the
replace-lightgbm-with-pytorch-for-visualisation-tutorial
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #5255
Description of the changes
The newly added PyTorch example comes from the multi-objective tutorial page: Multi-objective Optimization with Optuna. I've removed a few hyperparameters so as not to make the figure less clear due to overlapping text.