Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistencies between terminator and terminator visualization i… #5276

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix inconsistencies between terminator and terminator visualization i… #5276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion optuna/visualization/_terminator_improvement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
from optuna.terminator import BaseImprovementEvaluator
from optuna.terminator import CrossValidationErrorEvaluator
from optuna.terminator import RegretBoundEvaluator
from optuna.terminator.erroreval import StaticErrorEvaluator
from optuna.terminator.improvement.evaluator import BestValueStagnationEvaluator
from optuna.terminator.improvement.evaluator import DEFAULT_MIN_N_TRIALS
from optuna.visualization._plotly_imports import _imports

Expand Down Expand Up @@ -128,7 +130,10 @@
if improvement_evaluator is None:
improvement_evaluator = RegretBoundEvaluator()
if error_evaluator is None:
error_evaluator = CrossValidationErrorEvaluator()
if isinstance(improvement_evaluator, BestValueStagnationEvaluator):
error_evaluator = StaticErrorEvaluator(constant=0)

Check warning on line 134 in optuna/visualization/_terminator_improvement.py

View check run for this annotation

Codecov / codecov/patch

optuna/visualization/_terminator_improvement.py#L134 

Added line #L134 was not covered by tests
else:
error_evaluator = CrossValidationErrorEvaluator()

trial_numbers = []
completed_trials = []
Expand Down