Enhance GPSampler performance (other than introducing local search) #5279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5279 +/- ##
==========================================
+ Coverage 89.56% 89.58% +0.01%
==========================================
Files 209 209
Lines 13103 13144 +41
==========================================
+ Hits 11736 11775 +39
- Misses 1367 1369 +2 ☔ View full report in Codecov by Sentry. |
contramundum53
commented
Feb 26, 2024
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
|
@nabenabe0928 I applied your comments. PTAL. |
contramundum53
commented
Feb 29, 2024
contramundum53
commented
Feb 29, 2024
contramundum53
commented
Feb 29, 2024
nabenabe0928
reviewed
Mar 1, 2024
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
nabenabe0928
approved these changes
Mar 1, 2024
y0z
reviewed
Mar 1, 2024
| @@ -164,7 +166,8 @@ def _fit_kernel_params( | |||
| np.log(initial_kernel_params.inverse_squared_lengthscales.detach().numpy()), | |||
| [ | |||
| np.log(initial_kernel_params.kernel_scale.item()), | |||
| np.log(initial_kernel_params.noise_var.item() - minimum_noise), | |||
| # We add 0.01 * minimum_noise to initial noise_var to avoid instability. | |||
| np.log(initial_kernel_params.noise_var.item() - 0.99 * minimum_noise), | |||
There was a problem hiding this comment.
Based on the comment above (i.e., "add 0.01 * minimum_noise to initial noise_var"), I feel this line should be like below.
np.log(initial_kernel_params.noise_var.item() + 0.01 * minimum_noise)
There was a problem hiding this comment.
I think this line is trying to transform the variable so that the search space is gonna be
So probably, what @y0z wanted to say was actually this?
transformed_noise = initial_kernel_params.noise_var.item() - minimum_noise
...=np.log(transformed_noise + 0.01 * minimum_noise)There was a problem hiding this comment.
Memo: The intention is below.
(initial_noise_var + 0.01 * minimum_noise) - minimum_noise = initial_var - 0.99 * minimum_noise.
nabenabe0928
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We split PR #5274 into two. This PR introduces all improvements other than local search.
Description of the changes
See #5274.