-
-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance GPSampler performance (other than introducing local search) #5279
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
f843e46
Enhance GPSampler performance
contramundum53 ca29c1c
Merge branch 'master' of github.com:optuna/optuna into enhance-gp
contramundum53 db9d08c
Update optuna/_gp/gp.py
contramundum53 8eeff54
Merge branch 'master' of github.com:optuna/optuna into enhance-gp
contramundum53 275817f
Merge branch 'enhance-gp' of github.com:contramundum53/optuna into en…
contramundum53 be594c2
Update optuna/_gp/gp.py
contramundum53 6f9085a
Update optuna/samplers/_gp/sampler.py
contramundum53 9b29fcb
Update optuna/samplers/_gp/sampler.py
contramundum53 d0db266
Update optuna/_gp/prior.py
contramundum53 8b5eb9e
Rename deterministic -> deterministic_objective
contramundum53 6b1c98b
Merge branch 'enhance-gp' of github.com:contramundum53/optuna into en…
contramundum53 8809385
Fix argument name
contramundum53 04312eb
Update optuna/_gp/gp.py
contramundum53 0e0fdb1
Update optuna/_gp/prior.py
contramundum53 fb16fc7
Keep KernelParamsTensor frozen
contramundum53 97d34fa
Update optuna/_gp/prior.py
contramundum53 6d914c9
add comments
contramundum53 e019260
format
contramundum53 554d57e
Update optuna/samplers/_gp/sampler.py
contramundum53 5823e52
Update optuna/_gp/gp.py
contramundum53 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the comment above (i.e., "add 0.01 * minimum_noise to initial noise_var"), I feel this line should be like below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line is trying to transform the variable so that the search space is gonna be$(-\infty, \infty)$ .
So probably, what @y0z wanted to say was actually this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Memo: The intention is below.