-
-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation of Algorithim behind optuna #922
Conversation
By the way, you can check the CI (circleci) results from the links as the bottom of this PR. There is one currently failing, if you could take a look. |
@hvy |
The current format seem correct. Indeed you need an empty line but then there was this other error that it wasn't entirely empty but contained whitespaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation content basically LGTM. I left some comments. It by the way seems like you've included changes from other PRs. One way to fix your PR changes would be to rebase on the latest master, i.e. first update your local copy of the master git checkout master && git fetch <name of upstream> && git merge <name of upstream>/master --ff-only
and then git rebase -i master
.
Codecov Report
@@ Coverage Diff @@
## master #922 +/- ##
=========================================
- Coverage 90.32% 90.22% -0.1%
=========================================
Files 110 112 +2
Lines 9087 9293 +206
=========================================
+ Hits 8208 8385 +177
- Misses 879 908 +29
Continue to review full report at Codecov.
|
I see you're having some issues with organizing the commit history. If you really can't work it out, closing this PR and creating a new one is also fine. Just so you know. |
I believe this is the new PR that's replacing this one #940. |
This PR meets requirements related to issue in #835