Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated method(s) for forward compatibiltiy #77

Closed
adelowo opened this issue Jan 31, 2017 · 3 comments
Closed

Remove deprecated method(s) for forward compatibiltiy #77

adelowo opened this issue Jan 31, 2017 · 3 comments
Assignees
@davidbyoung
Labels
enhancement
Milestone
v2.0.0

Comments

@adelowo
Copy link

adelowo commented Jan 31, 2017

In the RFC for 7.2 deprecations, the each method was listed as one of the functions/language constructs to be removed in a future PHP version.

I see the function being used in the Lexer for fortune.
Relevant links -

Since this would throw a deprecated notice, i think it's best to be cleaned up before a general release of the next version.

Nice work though
@davidbyoung davidbyoung self-assigned this Jan 31, 2017
@davidbyoung
Copy link
Member

Nice catch. I'll take a look at how I can achieve the same thing without using deprecated functions.

@adelowo
Copy link
Author

adelowo commented Jan 31, 2017

That would be awesome.

@davidbyoung davidbyoung added this to the v2.0.0 milestone Jun 10, 2019
@davidbyoung
Copy link
Member

This has been finished in 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidbyoung davidbyoung

Labels
enhancement
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@davidbyoung @adelowo