Merge pull request #2804 from sbwalker/dev

Modify the FilterModuleDefinition() method to return null if the object passed to the method is null instead of returning an initialized object
oqtane · May 11, 2023 · 3698eba · 3698eba
2 parents 36e4a69 + f59a5c9
commit 3698eba
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/Oqtane.Server/Repository/ModuleDefinitionRepository.cs b/Oqtane.Server/Repository/ModuleDefinitionRepository.cs
@@ -62,11 +62,12 @@ public void DeleteModuleDefinition(int moduleDefinitionId)
 
         public ModuleDefinition FilterModuleDefinition(ModuleDefinition moduleDefinition)
         {
-            var ModuleDefinition = new ModuleDefinition();
+            ModuleDefinition ModuleDefinition = null;
 
             if (moduleDefinition != null)
             {
                 // only include required client-side properties
+                ModuleDefinition = new ModuleDefinition();
                 ModuleDefinition.ModuleDefinitionId = moduleDefinition.ModuleDefinitionId;
                 ModuleDefinition.SiteId = moduleDefinition.SiteId;
                 ModuleDefinition.ModuleDefinitionName = moduleDefinition.ModuleDefinitionName;