Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConltolPanel to use Bootstrap Offcanvas component #1554

Merged
merged 2 commits into from
Jul 18, 2021
Merged

ConltolPanel to use Bootstrap Offcanvas component #1554

merged 2 commits into from
Jul 18, 2021

Conversation

leigh-pointer
Copy link
Contributor

Offcanvas is a sidebar component that can be toggled on of off

@sbwalker
Copy link
Member

I do think it is a good idea to use the new native BS5 offcanvas component for the Control Panel because it is much more appropriate than the card component which is currently being used.

I do believe that as per the standard approach for all Oqtane controls, it still needs to have a selector "app-controlpanel" so that it is possible to target style overrides without affecting all offcanvas components in a site.

This means the current styles in app.css for app-controlpanel probably need to be modified or removed.

current styles in app.css and theme.css for app-controlpanel removed as no longer needed.

Removed the _display var as that is no longer beign used.
@sbwalker sbwalker merged commit 0e6baae into oqtane:dev Jul 18, 2021
@sbwalker
Copy link
Member

@leigh-pointer the user experience of the control panel has changed as a result of this PR. I would prefer if the previous behavior was retained where the control panel would be hidden if a user clicked on the page outside of the control panel - and also would be hidden when a user selected a button on the control panel such as Admin Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants