Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter deleted pages and modules on the server #3205

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

sbwalker
Copy link
Member

No description provided.

@sbwalker sbwalker merged commit ad57d66 into oqtane:dev Aug 28, 2023
1 check passed
@sbwalker
Copy link
Member Author

@leigh-pointer I was investigating a strange issue with Script Resources and I realized that deleted pages and modules were being sent from the server-side SiteController API to the client-side SiteRouter and were being processed by the UI composition logic. And then the PageState.Pages and PageState.Modules collections were later being filtered using the IsDeleted property so that consumers could only manage active entities.

This does not seem valid... as it is transferring more data than necessary between the server and client, and causing unnecessary processing of that data on the client.... only to later remove it before exposing it to consumers. Obviously I am responsible for this inefficiency... and it most likely happened when I did the performance optimization and aggregated multiple API method calls into a single consolidated GetSite() method.

So I am really just raising this in case you recall that there was a valid reason why these deleted entities needed to be sent to the client... which I may have forgotten. So far my testing indicates that this PR causes no side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant