Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Email column to User Manager screen #3293

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Add Email column to User Manager screen #3293

merged 2 commits into from
Sep 22, 2023

Conversation

W6HBR
Copy link
Contributor

@W6HBR W6HBR commented Sep 22, 2023

The logic for including this additional column is that the search functionality allows you to search on Username, DisplayName and Email. However, only the Username and DisplayName columns are displayed, so you don't have direct confirmation of the email search match. Additionally, looking up emails is one of the most used reasons that admins go to the User Manager screen.

@leigh-pointer
Copy link
Contributor

@W6HBR the name column is a href link to the email address. Entering part of an email address returns valid search results.

@sbwalker
Copy link
Member

sbwalker commented Sep 22, 2023

@leigh-pointer is correct... but perhaps this is not intuitive to most users - so maybe it would be better to explicitly show the Email address as a column (and move the href link from Name to Email).

@leigh-pointer
Copy link
Contributor

@sbwalker i had already implemented this sometime ago and the PR was rejected because of the number of columns needed to be considered for MAUI.

@W6HBR
Copy link
Contributor Author

W6HBR commented Sep 22, 2023

I added the HREF to the email address as well so both Name and Email are clickable. My need here was for display purposes to see the results with Email in addition to the Name.

When a user says they can't login and can't get a reset link, the email is always the first thing to check. As it is, for an Admin to see the email, they either have to hover over the name to see the link, click on the name to create a message (non-intuitive) or click edit to see the user record. Having the email displayed from the search/list results presents the cleanest and most intuitive result.

@sbwalker
Copy link
Member

sbwalker commented Sep 22, 2023

@leigh-pointer yes, you are correct that I rejected your PR in the past for this... and it wasn't specifically for MAUI - it was more related to trying to ensure the admin UI is still functional on a smaller screen size. One way to deal to with this is minimize the number of columns. Another way is to introduce horizontal scrolling of the grid component in cases where the screen screen is reduced - the Sql Management UI takes this approach (by adding a Bootstrap class):

<Pager Class="table table-bordered" Items="@_results">

@sbwalker sbwalker merged commit fd699cb into oqtane:dev Sep 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants