upated LanguageSwitcher with end padding #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the LanguageSwitcher is dsiplayed the wsa no end padding on the button so it appeared flush with the following button. Adding "pe-1" to the class corrects the issue
|
Please screenshot how the change looks like before & after? |
|
Before! After! |
|
Please double-check in RTL. |
|
It will not effect anything to do with RTL because it is button padding and nothing to do with text. |
|
From the screenshot, I see there is right padding has been added, which certainly will affect the RTL |
|
@hishamco I do not believe anyone has reviewed Oqtane for RTL support in general |
|
I might need to do that while I am an Arabic guy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the LanguageSwitcher is dsiplayed the wsa no end padding on the button so it appeared flush with the following button. Adding "pe-1" to the class corrects the issue