Line wrapping bug #271
Merged
Line wrapping bug #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
All good after the changes we made this morning. I've added a few minor ones in the last minutes. @sgrieve please review and merge if happy. |
raquelalegre
approved these changes
Aug 18, 2017
|
With these maven changes, and some updates to the wiki and readme which have been made, we can close issue #231 as well 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new java classes to fix the line wrapping bug. The problem was introduced in Java 7 and has nothing to do with our implementation.
This stack overflow answer provided Java classes which we have modified lightly to work in a more general context.
So we now have 4 more java classes to compile and include in the maven build process. At present this is done by committing the class files, but we should pick up issue #231 and get a better maven build process going, and document it properly, but I think that is a problem for post 1.0 release.
This fixes issue #265.