Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add support for M1 MAC runners #71

Closed
wants to merge 1 commit into from

Conversation

sureshg
Copy link

@sureshg sureshg commented Jan 31, 2024

Github action recently added support for MacOS M1 runner (https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) and is free for public repos. Since the action script hardcoded JAVA_HOME for x86 arch, tit won't run on ARM64 machines. This PR will fix that.

Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jan 31, 2024
@sormuras
Copy link
Member

Duplicate of PR #64?

@sureshg
Copy link
Author

sureshg commented Jan 31, 2024

@sormuras yeah it's the same. But shouldn't we need to change other workflows too where we are accessing JAVA_HOME and runs-on multiple runners? Feel free to close this if you are planning to merge the other PR.

sormuras added a commit that referenced this pull request Feb 1, 2024
@sormuras sormuras closed this in c9a099b Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants