RHS captures all s-expressions using implicit do
#119
Conversation
|
This was the smallest change I could make to get the desired functionality. Probably better would be to simply return the original captured collection as rhs (and adjust defrule to check if it's empty instead of checking for nil), but doing this caused some problems in parse-rule*, so I backed it out. Let me know if you want me to make that change, and I can take another shot at it. I wanted to at least get this to you for review, and I just had my lunch break to do it. |
|
Yes, I think the minimal approach is the way to go here. We could update parse-rule*, but that's used elsewhere in test code and in a (not publicly available) library that generates rules. |
RHS captures all s-expressions using implicit `do`
|
I went ahead and merged this. Thanks for the contribution! We can probably do a fix release with this (and a couple other recent fixes) if desired. |
|
No problem - thanks for the lib! No rush on the release. We're happily using it as is; I just figured I'd ask/fix it, if ya'll were interested. Seriously, rule engines rock. How did I not know this?! ;-) |
Regarding issue #118