Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom route rules to the NAT gateway #17

Closed
hyder opened this issue Jan 15, 2021 · 2 comments · Fixed by #32
Closed

Add custom route rules to the NAT gateway #17

hyder opened this issue Jan 15, 2021 · 2 comments · Fixed by #32
Labels
enhancement New feature or request
Milestone
v2.2.0

Comments

@hyder
Copy link
Contributor

hyder commented Jan 15, 2021

When adding connectivity to on premise networks, we need to be able to add configurable route rules to the relevant on-premise CIDR blocks and route it through a DRG. These route rules should be added to the NAT route table as it will be used by private subnets.
@hyder
Copy link
Contributor Author

hyder commented Jan 15, 2021

Dependant on #16

kral2 added a commit to kral2/terraform-oci-vcn that referenced this issue Mar 11, 2021
@kral2
Add feature Create custom routing rules
f71f68a 
Fix issue oracle-terraform-modules#17 (Add custom route rules to the NAT gateway)
Add all_attributes outputs for each provisionned resources
Add new example for custom routing rules
Add service_gateway_id output

Signed-off-by: Çetin ARDAL <cetin.ardal@oracle.com>
@kral2 kral2 mentioned this issue Mar 11, 2021
Merged
@hyder hyder linked a pull request Mar 12, 2021 that will close this issue
Add feature Create custom routing rules #32
Merged
@hyder hyder closed this as completed in #32 Mar 18, 2021
hyder pushed a commit that referenced this issue Mar 18, 2021
@kral2
Add feature Create custom routing rules (#32)
67e797e 
* Add feature Create custom routing rules

Fix issue #17 (Add custom route rules to the NAT gateway)
Add all_attributes outputs for each provisionned resources
Add new example for custom routing rules
Add service_gateway_id output

Signed-off-by: Çetin ARDAL <cetin.ardal@oracle.com>

* fix broken link

Signed-off-by: Çetin ARDAL <cetin.ardal@oracle.com>

* add suggested changes from PR Review

- remove new all_attributes outputs, will be integrated in another PR
- clarification comments on dynamic blocks for routing rules
- custom_route_rules example now shows two methods to pass rules: Variable Inputs or Local Values

Signed-off-by: Çetin ARDAL <cetin.ardal@oracle.com>

* fix typo in documentation

Signed-off-by: Çetin ARDAL <cetin.ardal@oracle.com>
@kral2 kral2 added this to the v2.2.0 milestone Mar 19, 2021
@kral2 kral2 added the enhancement New feature or request label Mar 19, 2021
@kral2
Copy link
Contributor

kral2 commented Mar 24, 2021

🎉 This issue has been resolved in version v2.2.0 🎉

The release is available here

@kral2 kral2 mentioned this issue Aug 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

Add feature Create custom routing rules kral2/terraform-oci-vcn
2 participants
@hyder @kral2