Improved model deployment progress bar #144
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
| poll_interval: int = DEFAULT_POLL_INTERVAL, | ||
| ): | ||
| """_wait_for_progress_completion blocks until progress is completed. | ||
| def _wait_for_work_request( |
There was a problem hiding this comment.
In the ticket it says that progress bar should be implemented as part of a Mixin class, but the implementation is different. Shouldn't we have some solution that can be reused for the different services the we do support?
There was a problem hiding this comment.
Thanks, the method has been moved to class OCIWorkRequestMixin for general use.
| @@ -29,6 +30,10 @@ | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
| LIFECYCLE_STOP_STATE = ("SUCCEEDED", "FAILED", "CANCELED", "DELETED") | |||
| WORK_REQUEST_STOP_STATE = ("SUCCEEDED", "FAILED", "CANCELED") | |||
There was a problem hiding this comment.
This might depend on the service.
There was a problem hiding this comment.
These are the WorkRequest terminal states and do the services have different values?
| def wait_for_progress( | ||
| self, | ||
| work_request_id: str, | ||
| num_steps: int = DEFAULT_WORKFLOW_STEPS, |
There was a problem hiding this comment.
It does not seem like there is an easy way to know the number of workflow steps for different workflow. Having a default here could be confusing for the developers. I think a better behavior is, while the number of steps is not specified, it will continue waiting until work_request.status reach WORK_REQUEST_STOP_STATE. Even though WORK_REQUEST_STOP_STATE still depends on the workflow, most, if not all workflow has SUCCEEDED and FAILED states.
Improved model deployment progress bar
OCIWorkRequestMixinclass so that it can be used by other services.Notebook