Fixed unpatched object storage url bug in unit test #340
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Please add a Jira ticket if there is one. |
|
📌 Cov diff with main: No success to gather report. 😿 📌 Overall coverage: No success to gather report. 😿 |
|
|
📌 Cov diff with main: No success to gather report. 😿 📌 Overall coverage: No success to gather report. 😿 |
1 similar comment
|
📌 Cov diff with main: No success to gather report. 😿 📌 Overall coverage: No success to gather report. 😿 |
|
|
📌 Cov diff with main: 📌 Overall coverage: |
| """prepare a model by only providing inference conda env.""" | ||
| inference_conda_env="oci://service-conda-packs@ociodscdev/service_pack/cpu/General_Machine_Learning_for_CPUs/1.0/mlcpuv1" |
There was a problem hiding this comment.
Can it be used more dummy values, something like this:
oci://bucket@namespace/prefix
| @@ -57,7 +57,7 @@ dependencies = [ | |||
| "asteval>=0.9.25", | |||
| "cerberus>=1.3.4", | |||
| "cloudpickle>=1.6.0", | |||
| "fsspec>=0.8.7", | |||
| "fsspec>=0.8.7,<2023.9.1", # v2.9.1 introduced issues, releved by unit tests | |||
There was a problem hiding this comment.
revealed instead of releved. Not critical, I can update type with my PR in future
| @@ -109,7 +109,7 @@ onnx = [ | |||
| "lightgbm==3.3.1", | |||
| "onnx>=1.12.0", | |||
| "onnxmltools>=1.10.0", | |||
| "onnxruntime>=1.10.0", | |||
| "onnxruntime>=1.10.0,<1.16", # v1.16 introduced issues https://github.com/microsoft/onnxruntime/issues/17631, releved by unit tests | |||
There was a problem hiding this comment.
revealed instead of releved. Not critical, I can update type with my PR in future
Fixed unpatched object storage url bug in unit test.