Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signer exception fix v2.11.9 #809

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Signer exception fix v2.11.9 #809

merged 4 commits into from
Apr 25, 2024

Conversation

VipulMascarenhas
Copy link
Member

Description

The jupyter build fails as the default_signer() throws an oci.exceptions.ConfigFileNotFound. The load_config inside fetch_service_compartment has been updated to catch all generic exceptions.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 25, 2024
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

darenr
darenr previously approved these changes Apr 25, 2024
ads/aqua/utils.py Outdated Show resolved Hide resolved
Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

Copy link

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-61.57%

Copy link

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@VipulMascarenhas VipulMascarenhas merged commit 7e89d18 into main Apr 25, 2024
12 of 13 checks passed
@VipulMascarenhas VipulMascarenhas deleted the signer_exception_fix branch April 25, 2024 06:27
Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-61.57%

1 similar comment
Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-61.57%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants