Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves the extraction of custom metadata items by key. #813

Merged
merged 1 commit into from
May 1, 2024

Conversation

mrDzurb
Copy link
Member

@mrDzurb mrDzurb commented May 1, 2024

Description

Improves the extraction of custom metadata items by key.
now it supports providing a value to return if the specified key does not exist.

assert metadata.get("NoneExistingKey", None) == None

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 1, 2024
@darenr
Copy link
Member

darenr commented May 1, 2024

I had to lookup the subtle difference between abstract method and abstract class method.

@mrDzurb mrDzurb merged commit 7ae0515 into feature/aquav1.0.2 May 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants