Odsc-56003/fix eval delete #818
Conversation
mingkang111
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas and
qiuosier
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
| @@ -367,6 +367,9 @@ class AquaEvaluationApp(AquaApp): | |||
| _report_cache = TTLCache(maxsize=10, ttl=timedelta(hours=5), timer=datetime.now) | |||
| _metrics_cache = TTLCache(maxsize=10, ttl=timedelta(hours=5), timer=datetime.now) | |||
| _eval_cache = TTLCache(maxsize=200, ttl=timedelta(hours=10), timer=datetime.now) | |||
| _deletion_cache = TTLCache( | |||
There was a problem hiding this comment.
any reason we've selected 10 mins, or this is arbitrary?
| jobrun = None | ||
|
|
||
| self._eval_cache.pop(key=eval_id, default=None) | ||
| self._deletion_cache.__setitem__(key=eval_id, value="") |
There was a problem hiding this comment.
curious about this: would this cache be set incorrectly if the _delete_job_and_model comes across ServiceError while deleting resources? In that case, will the list API will show status as DELETED for 10 mins (TTL duration) and and then get updated with the correct status?
| job_run_status = jobrun.lifecycle_state | ||
|
|
||
| if jobrun is None: | ||
| if model.identifier in self._deletion_cache.keys(): |
There was a problem hiding this comment.
wouldn't this show DELETED status when list API is called even if the job run is still in the process of being deleted?
There was a problem hiding this comment.
Hi @VipulMascarenhas , jobrun status is tracked by rqs in LIST. So if job run is still active (i.e. jobrun status != deleted), the jobrun will not be None, and the real status will be used. For jobrun has been deleted by DELETE Button in AQUA, RQS won't be able to track that jobrun, and the jobrun status should show as DELETED in this case.
Description
This PR aims to fix status for DELETING/DELETED evaluation:
Changed
_get_statusto return correct status under different cases.DELETINGif real status not available.TODO
Test