Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config validation and telemetry #872

Merged
merged 1 commit into from
May 31, 2024

Conversation

VipulMascarenhas
Copy link
Member

Description

This PR adds the the following changes:

  1. Validate model_type in config.json: If custom metadata has this attribute, then check if config.json is available in the user bucket where artifacts are loaded from.
  2. Bug fix: after registering model, model card should return the readme from the user bucket instead of verified model bucket.
  3. Record telemetry information after registering models.
  4. Updated Unit Tests.

Unit Tests

> python -m pytest -q tests/unitary/with_extras/aqua/test_model*.py
==================================== test session starts ====================================
platform darwin -- Python 3.8.18, pytest-7.4.0, pluggy-1.0.0
rootdir: /Users/vmascarenhas/workspace/git/accelerated-data-science
configfile: pytest.ini
plugins: Faker-24.9.0, anyio-4.2.0
collected 24 items

tests/unitary/with_extras/aqua/test_model.py .................                        [ 70%]
tests/unitary/with_extras/aqua/test_model_handler.py .......                          [100%]

==================================== 24 passed in 3.60s =====================================

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 31, 2024
@VipulMascarenhas VipulMascarenhas merged commit 4398d3b into feature/aquav1.0.2 May 31, 2024
2 checks passed
@VipulMascarenhas VipulMascarenhas deleted the register_models_telemetry branch May 31, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants