Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update restricted params #874

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

VipulMascarenhas
Copy link
Member

Description

This PR adds more parameters that are restricted to be overridden by the user. Some params like "served-model-name", "seed", "sharded", "trust-remote-code" are already disallowed by in the backed as they're present in container_index.json, we'll add them here as well for reference.

Unit Tests

> python -m pytest -q tests/unitary/with_extras/aqua/test_model*.py
=================================== test session starts ===================================
platform darwin -- Python 3.8.18, pytest-7.4.0, pluggy-1.0.0
rootdir: /Users/user/workspace/git/accelerated-data-science
configfile: pytest.ini
plugins: Faker-24.9.0, anyio-4.2.0
collected 24 items

tests/unitary/with_extras/aqua/test_model.py .................                      [ 70%]
tests/unitary/with_extras/aqua/test_model_handler.py .......                        [100%]

=================================== 24 passed in 3.73s ====================================


> python -m pytest -q tests/unitary/with_extras/aqua/test_deployment*
=================================== test session starts ===================================
platform darwin -- Python 3.8.18, pytest-7.4.0, pluggy-1.0.0
rootdir: /Users/user/workspace/git/accelerated-data-science
configfile: pytest.ini
plugins: Faker-24.9.0, anyio-4.2.0
collected 29 items

tests/unitary/with_extras/aqua/test_deployment.py ....................              [ 68%]
tests/unitary/with_extras/aqua/test_deployment_handler.py ..s......                 [100%]

============================== 28 passed, 1 skipped in 7.25s ==============================

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 4, 2024
@VipulMascarenhas VipulMascarenhas merged commit 6248583 into feature/aquav1.0.2 Jun 4, 2024
2 checks passed
@VipulMascarenhas VipulMascarenhas deleted the additional_restricted_params branch June 4, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants