Vault support for Forecast & AD operators #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govarsha
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas and
qiuosier
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
ahosler
reviewed
Jun 7, 2024
| if vault_secret_id is not None: | ||
| try: | ||
| with ADBSecretKeeper.load_secret(vault_secret_id, wallet_dir=temp_dir) as adwsecret: | ||
| if 'wallet_location' in adwsecret and 'wallet_location' not in connect_args: |
There was a problem hiding this comment.
Great handling here! Connect_args can overwrite the Vault.
There was a problem hiding this comment.
@ahosler Added unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When vault_secret_id is mentioned in input data schema, operators will fetch the database credentials from Vault.