Adds timeout option for loading AQUA config. #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrDzurb
requested review from
darenr,
mayoor,
VipulMascarenhas and
qiuosier
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
darenr
previously approved these changes
Jun 10, 2024
mayoor
previously approved these changes
Jun 10, 2024
VipulMascarenhas
previously approved these changes
Jun 10, 2024
|
@mrDzurb unit tests need to be updated for this change. |
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
dismissed stale reviews from VipulMascarenhas, mayoor, and darenr
via
06ce342
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
mingkang111
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, notebook sessions without a configured SGW began encountering errors related to loading the AQUA starter config. This PR resolves the issue by adding a timeout option to the config loading operation.