Added ruff for pre-commit check #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added repo to .pre-commit-config.yaml - added rules to pyproject.toml - removed black, because ruff has drop-in parity with it
liudmylaru
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas and
qiuosier
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
|
mrDzurb
previously approved these changes
Jun 19, 2024
darenr
previously approved these changes
Jun 19, 2024
|
📌 Cov diff with main: No lines with coverage information in this diff. 📌 Overall coverage: |
- added ignore and extended-select - added types_or: [ python, pyi, jupyter ] to config
|
|
📌 Cov diff with main: No lines with coverage information in this diff. 📌 Overall coverage: |
VipulMascarenhas
approved these changes
Jun 20, 2024
mrDzurb
approved these changes
Jun 20, 2024
|
|
📌 Cov diff with main: No lines with coverage information in this diff. 📌 Overall coverage: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ruff can be used to replace Flake8 (plus dozens of plugins), Black, isort, pydocstyle, and more, all while executing tens or hundreds of times faster than any individual tool.
Added ruff to run mainly default settings with little extra and exclude. While developing our code we will add/exclude more. Please check on rules and suggest what can be added to default (section 'select' in pyproject.toml) and what can be excluded (section 'ignore' in pyproject.toml)- https://docs.astral.sh/ruff/rules/.
What was done