Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl scale can fail if the replicas field is not set #368

Closed
thegridman opened this issue Nov 14, 2019 · 0 comments
Closed

kubectl scale can fail if the replicas field is not set #368

thegridman opened this issue Nov 14, 2019 · 0 comments
Assignees
@thegridman

Comments

@thegridman
Copy link
Member

It seems that some versions of kubectl prior to 1.16.0 can fail if the kubectl scale command is run for a role that did not have a specific replicas value set.

We should ensure that even if the initial CoherenceCluster does not specify a replicas value that it is deflated in any CoherenceRoles that are created.
@thegridman thegridman self-assigned this Nov 14, 2019
thegridman added a commit that referenced this issue Nov 14, 2019
@thegridman
Issue #368 - ensure that roles always have a replica value
cabb19a
thegridman added a commit that referenced this issue Nov 14, 2019
@thegridman
Issue #368 - amend scale to zero test role to not have a replica count
0b86518
thegridman added a commit that referenced this issue Nov 14, 2019
@thegridman
Issue #368 - test modification
eee8928
thegridman added a commit that referenced this issue Nov 15, 2019
@thegridman
Issue #368 - ensure that all roles have a replica count set
981b32e 
* Issue #368 - ensure that roles always have a replica value

* Issue #368 - amend scale to zero test role to not have a replica count

* Issue #368 - test modification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thegridman thegridman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thegridman