Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix to include size, scale and precision in column.datatype #30

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Bugfix to include size, scale and precision in column.datatype #30

merged 2 commits into from
Jul 8, 2022

Conversation

aosingh
Copy link
Member

@aosingh aosingh commented Jul 8, 2022

  1. Fixes Bug [Bug] Column.data_type does not take into account the data_length #29
  2. Introduced new class OracleColumn which can be used to define logic specific to Oracle table column
  3. Added an example model in dbt_adbs_test_project to reproduce the error and validate the fix
  4. Added a project specific macro in dbt_adbs_test_project to translate the string datatype

@aosingh
Bugfix to include size, scale and precision in column.datatype
0ee5978 
1. Fixes Bug #29
2. Introduced new class OracleColumn which can be used to define logic specific to Oracle table column
3. Added an example model in dbt_adbs_test_project to reproduce the error and validate the fix
4. Added a project specific macro in dbt_adbs_test_project to translate the string datatype
@aosingh
Added newlines in missing files
45a6a30
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 8, 2022
ramapemmaraju
ramapemmaraju approved these changes Jul 8, 2022
View reviewed changes
Copy link

@ramapemmaraju ramapemmaraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@aosingh aosingh merged commit b4ca3c1 into main Jul 8, 2022
@aosingh aosingh deleted the fix/column_datatype branch July 14, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramapemmaraju ramapemmaraju ramapemmaraju approved these changes

@spanchum spanchum spanchum approved these changes

@thbaby thbaby Awaiting requested review from thbaby

@rkope99 rkope99 Awaiting requested review from rkope99

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aosingh @ramapemmaraju @spanchum