Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support merge_update_columns configuration for incremental models #35

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Support merge_update_columns configuration for incremental models #35

merged 1 commit into from
Jul 14, 2022

Conversation

aosingh
Copy link
Member

@aosingh aosingh commented Jul 14, 2022

  • Changed the incremental strategy macro to support merge_update_columns config
  • Added an adapter test case to verify the implementation

@aosingh
Support merge_update_columns configuration for incremental models
8bc8ecd 
- Changed the increment MERGE macro
- Added an adapter test case to verify the  implementation
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 14, 2022
@aosingh aosingh requested a review from spanchum July 14, 2022 22:53
spanchum
spanchum approved these changes Jul 14, 2022
View reviewed changes
Copy link

@spanchum spanchum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aosingh aosingh merged commit 1e5658f into main Jul 14, 2022
@aosingh aosingh deleted the feature/incr_merge_update_columns branch July 15, 2022 00:46
@aosingh aosingh mentioned this pull request Jul 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spanchum spanchum spanchum approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aosingh @spanchum