fix(database): cgroup v2 compatibility #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The memory check in the runOracle script takes the cgroup version into account. Fixes oracle#1939 Signed-off-by: Philippe Vanhaesendonck <philippe.vanhaesendonck@oracle.com>
|
I appreciate your input on this one.
If you think it is good to go, I'll push this fix for the other versions as well |
memory.max is what the container runtime uses and we can have memory.max < memory.high Signed-off-by: Philippe Vanhaesendonck <philippe.vanhaesendonck@oracle.com>
gvenzl
previously approved these changes
Jun 9, 2021
Djelibeybi
previously approved these changes
Jun 11, 2021
|
Looks good to me. |
Apply previous commit to the other DB container image scripts Signed-off-by: Philippe Vanhaesendonck <philippe.vanhaesendonck@oracle.com>
|
Applied the same changes to all scripts using Ready to be merged. |
gvenzl
approved these changes
Jun 11, 2021
|
Needs @psaini79 to approve for the RAC case. |
|
Is there a chance to expedite this for Single Instance, i.e., file a PR with these changes for just the SI changes? :) |
|
I believe we gave @psaini79 sufficient time for review. I will merge it anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory check in the runOracle script takes the cgroup version into
account.
Fixes #1939
Signed-off-by: Philippe Vanhaesendonck philippe.vanhaesendonck@oracle.com