New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: switch to using the full oraclelinux:8 base image for the Oracle Linux Developer images #2020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2.7-node
image seems fine. I've hit an issue with compiling native gem extensions in the 2.7
image, but it's consistent with the current (official) image, so I'll look at this once we've fattened the images.
That would be great. |
Can you clarify how you would like to transition to Is the plan to re-base all dev images on the For the migrated images (like your |
No, we have to maintain When the next update is released, my plan is to replace At the next update, we can finalise the switch by removing the module files and switching directly to the |
OracleLinuxDevelopers/oraclelinux8/nodejs/14-oracledb/Dockerfile
Outdated
Show resolved
Hide resolved
Once #2044 is merged and the |
@AmedeeBulle I would deeply appreciate it if you could fix the workflow breakage I caused. :) |
@AmedeeBulle @mark-au @totalamateurhour can I please get another review/approval from one of you? I'd like to merge this sooner rather than later. |
OracleLinuxDevelopers/oraclelinux8/nodejs/14-oracledb/Dockerfile
Outdated
Show resolved
Hide resolved
This change modifies the base image used by the Oracle Linux 8 based images from the slim variant to the full variant for better developer alignment, i.e. availability of the dnf tool. An intermediate compat image is used to install microdnf so that existing tooling for these images doesn't break. Signed-off-by: Avi Miller <avi.miller@oracle.com>
Signed-off-by: Avi Miller <avi.miller@oracle.com>
Signed-off-by: Avi Miller <avi.miller@oracle.com>
But ensure that microdnf still works for users with existing downstream automation. Signed-off-by: Avi Miller <avi.miller@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the two with DB drivers; they build and run fine.
- Can/should you augment the slim note to say whether users should migrate from microdnf?
- Technically you can remove the explicit install of oracle-instantclient-basic since that gets pulled in automatically. I'm in two minds about 'hiding' this, since the result is the same.
- There is at least one changed file with only a 2020 copyright.
Signed-off-by: Avi Miller <avi.miller@oracle.com>
Signed-off-by: Avi Miller <avi.miller@oracle.com>
Thanks @cjbj, I've pushed changes to the main |
@AmedeeBulle @totalamateurhour @mark-au it would be great to get another review, but I will be merging this change in regardless by the end of the week, because we need to stop using |
Making this two distinct steps as an example of how modularity works. Signed-off-by: Avi Miller <avi.miller@oracle.com>
This makes the developer images far more developer-friendly by including such useful tools as a module-aware
dnf
and more. Yes, the images jump in size, but then developer images are inherently larger because of their purpose.Of particular importance is for folks to test the builds at https://github.com/Djelibeybi?tab=packages to make sure current functionality is unaffected, including any downstream CI/CD tooling that assumes the existence of
microdnf
.