Oracle GoldenGate

[sbalousek]

• Initial files to support containerized execution of Oracle GoldenGate 23

[Djelibeybi]

It occurred to me when I finished the review that all the strings that have spaces between the letters could actually be removed without any loss of context. I figured I'd mention that here instead of going back and editing all those review comments.

Also, the reason why the copyright lines need to be 2024 is because the files themselves are new. The age of the content in those files is irrelevant in this regard.

[sbalousek]

Thanks for your time, @Djelibeybi !

[Djelibeybi]

Thanks for your time, @Djelibeybi !

You're welcome. :)

[sbalousek]

@Djelibeybi - One last thing: we cannot merge until OGG 23 is released. I will let you know.

[Djelibeybi]

There are two very minor things I spotted but they're far from release blockers. You can decide whether or not you want to address them while the PR is still in draft mode.

[sbalousek]

Hi @Djelibeybi - I am having trouble finding the error in the super linter check. Any pointers would be appreciated.

[Djelibeybi]

Hi @Djelibeybi - I am having trouble finding the error in the super linter check. Any pointers would be appreciated.

The linting issues are being found by SHELL_SHFMT and can be seen by expanding that section or by clicking here: https://github.com/oracle/docker-images/actions/runs/8926398614/job/24517335048?pr=2780#step:5:233

[Djelibeybi]

Though, now that I'm looking at it closely, I'm not sure I agree with the linter on a few things (like its suggested indentation or lack thereof). I'll take a closer look tomorrow or over the weekend and tweak the linter as necessary. If you feel the linter is being overly pedantic, let me know and I'll merge after I do a final manual check.

[sbalousek]

I simply do not see the error. The shfmt tool is too aggressive with regard to whitespace, marking style differences as errors. I made the suggested corrections, which are still failing for no apparent reason. When I run shfmt locally, the return code is 0 for all files using shfmt -w -i 4.

As far as I can tell, this PR failed because shfmt expects TAB indentation, which I don't agree with. Other than that, I see no errors.

shfmt did, however, find an issue that ShellCheck did not.

[sbalousek]

These changes - which are critical to the GoldenGate 23ai release - passed lint checks a few weeks ago. If there is anything you can do before next week, I would really appreciate it.

[sbalousek]

I thought about this more and realized TAB characters are the current requirement (per shfmt), so I reformatted and tested the scripts.

[Djelibeybi]

I dislike Tab for whitespace too, so I'll adjust the SHFMT configuration accordingly so it doesn't flag that as an error in future. I'll approve and merge this in the meantime though.

[sbalousek]

Thanks a bunch, Avi. Have a fantastic weekend!

[Djelibeybi]

Thanks a bunch, Avi. Have a fantastic weekend!

You're welcome and likewise.