Skip to content

Commit

Permalink
Eliminate no-longer-needed DT_CG_ALLOCA_NULLPTR workaround
Browse files Browse the repository at this point in the history
Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com
  • Loading branch information
euloh authored and kvanhees committed Apr 29, 2022
1 parent ba7fd1a commit 5c50bcd
Showing 1 changed file with 0 additions and 20 deletions.
20 changes: 0 additions & 20 deletions bpf/inet_ntoa.S
Original file line number Diff line number Diff line change
Expand Up @@ -155,26 +155,6 @@ dt_inet_ntoa:
mov SRC, %r1
mov DST, %r2

#if 1
#define BPF_FUNC_probe_read 4
/*
* FIXME: copy src data over
*
* Currently, the code generator's handling of DT_CG_ALLOCA_NULLPTR
* is such that there are scenarios where the BPF verifier thinks an
* unsuitable value is being passed in as the "src" argument. Until
* this is fixed, simply use bpf_probe_read() to copy the src data
* onto the BPF stack. Reset the src argument to point to that
* stack location.
*/
mov %r3, %r1
mov %r2, 4
mov SRC, %fp
add SRC, -4
mov %r1, SRC
call BPF_FUNC_probe_read
#endif

mov %r3, 0
lddw LEN, STRSZ

Expand Down

0 comments on commit 5c50bcd

Please sign in to comment.