Skip to content

Commit

Permalink
test: Bump up locked memory in lockmem tests
Browse files Browse the repository at this point in the history
The default aggsize is 4M.  This is the dominant drain on locked
memory for a simple script like "BEGIN { @ = avg(1) }".

The lockmem tests check behavior when the lockmem limit is too
small; anything less than 4M is suitable.

They also check when the lockmem limit is large enough.  We were
using a lockmem limit of 16M, which is clearly inadequate even
for only a few CPUs.

Bump the "large enough" sizes up to 256M, which should be sufficient
even for dozens of CPUs.

Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
  • Loading branch information
euloh authored and kvanhees committed Sep 9, 2022
1 parent fa470e4 commit 672c453
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion test/unittest/misc/tst.lockmem-cmdline.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

dtrace=$1

for val in 1 16384 unlimited; do
for val in 1 262144 unlimited; do
ulimit -l $val

$dtrace -qn 'BEGIN { @ = avg(1234); exit(0); }'
Expand Down
2 changes: 1 addition & 1 deletion test/unittest/misc/tst.lockmem-envvar.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dtrace=$1

ulimit -l 1

for val in 16 1K 16384K 16M unlimited; do
for val in 16 1K 262144K 256M unlimited; do
DTRACE_OPT_LOCKMEM=$val $dtrace -qn 'BEGIN { @ = avg(1234); exit(0); }'
echo $?
done
Expand Down
2 changes: 1 addition & 1 deletion test/unittest/misc/tst.lockmem-pragma.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dtrace=$1

ulimit -l 1

for val in 16 1K 16384K 16M unlimited; do
for val in 16 1K 262144K 256M unlimited; do
$dtrace -qs /dev/stdin << EOF
#pragma D option lockmem=$val
Expand Down
2 changes: 1 addition & 1 deletion test/unittest/misc/tst.lockmem-x.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dtrace=$1

ulimit -l 1

for val in 16 1K 16384K 16M unlimited; do
for val in 16 1K 262144K 256M unlimited; do
$dtrace -xlockmem=$val -qn 'BEGIN { @ = avg(1234); exit(0); }'
echo $?
done
Expand Down

0 comments on commit 672c453

Please sign in to comment.