Skip to content

Commit

Permalink
Eliminate fun since it is always dt_agg_one_agg now
Browse files Browse the repository at this point in the history
Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
  • Loading branch information
kvanhees committed Aug 31, 2022
1 parent da2b172 commit 9fec684
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions libdtrace/dt_aggregate.c
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,6 @@ typedef struct dt_snapstate {
processorid_t cpu;
char *buf;
dt_aggregate_t *agp;
agg_cpu_f fun;
} dt_snapstate_t;

static void
Expand Down Expand Up @@ -479,12 +478,13 @@ dt_aggregate_snap_one(dt_idhash_t *dhp, dt_ident_t *aid, dt_snapstate_t *st)
/* Entry found - process the data. */
agd = &h->dtahe_data;

st->fun(aid, (int64_t *)agd->dtada_data, src, datasz);
dt_agg_one_agg(aid, (int64_t *)agd->dtada_data, src, datasz);

/* If we keep per-CPU data - process that as well. */
if (agd->dtada_percpu != NULL)
st->fun(aid, (int64_t *)agd->dtada_percpu[st->cpu],
src, datasz);
dt_agg_one_agg(aid,
(int64_t *)agd->dtada_percpu[st->cpu],
src, datasz);

return 0;
}
Expand Down Expand Up @@ -558,7 +558,7 @@ dt_aggregate_snap_one(dt_idhash_t *dhp, dt_ident_t *aid, dt_snapstate_t *st)
}

static int
dt_aggregate_snap_cpu(dtrace_hdl_t *dtp, processorid_t cpu, agg_cpu_f fun)
dt_aggregate_snap_cpu(dtrace_hdl_t *dtp, processorid_t cpu)
{
dt_aggregate_t *agp = &dtp->dt_aggregate;
char *buf = agp->dtat_cpu_buf[cpu];
Expand All @@ -568,7 +568,6 @@ dt_aggregate_snap_cpu(dtrace_hdl_t *dtp, processorid_t cpu, agg_cpu_f fun)
st.cpu = cpu;
st.buf = buf;
st.agp = agp;
st.fun = fun;

return dt_idhash_iter(dtp->dt_aggs,
(dt_idhash_f *)dt_aggregate_snap_one, &st);
Expand Down Expand Up @@ -598,8 +597,7 @@ dtrace_aggregate_snap(dtrace_hdl_t *dtp)
return dt_set_errno(dtp, -rval);

for (i = 0; i < dtp->dt_conf.num_online_cpus; i++) {
rval = dt_aggregate_snap_cpu(dtp, dtp->dt_conf.cpus[i].cpu_id,
dt_agg_one_agg);
rval = dt_aggregate_snap_cpu(dtp, dtp->dt_conf.cpus[i].cpu_id);
if (rval != 0)
return rval;
}
Expand Down

0 comments on commit 9fec684

Please sign in to comment.