-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The aggpercpu option appears in the documentation. Further, the current implementation has vestigial code that suggests the option was once supported. On the other hand, its behavior is not particularly described in the documentation. Further, it seems the option has no effect on Solaris or with the legacy Linux implementation. An easy workaround is to add cpu as a key to an aggregation; this workaround makes the feature superfluous. Another challenge is that it's hard to know what behavior makes most sense if aggpercpu is combined with other features. For quantize() output, should the same row values be used for all CPUs as for the overall aggregation? What should the output format look like if aggpercpu is combined with a printa() that has multiple aggregations? Just implement some reasonable version of aggpercpu support and leave intricate scenarios for the user to handle. Signed-off-by: Eugene Loh <eugene.loh@oracle.com> Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
- Loading branch information
Showing
3 changed files
with
206 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| #!/bin/bash | ||
| # | ||
| # Oracle Linux DTrace. | ||
| # Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. | ||
| # Licensed under the Universal Permissive License v 1.0 as shown at | ||
| # http://oss.oracle.com/licenses/upl. | ||
| # | ||
|
|
||
| dtrace=$1 | ||
|
|
||
| DIRNAME="$tmpdir/aggpercpu.$$.$RANDOM" | ||
| mkdir -p $DIRNAME | ||
| cd $DIRNAME | ||
|
|
||
| # | ||
| # Run a D script that fires on every CPU, | ||
| # forcing DTrace to aggregate results over all CPUs. | ||
| # | ||
|
|
||
| $dtrace -xaggpercpu -qn ' | ||
| profile-600ms | ||
| { | ||
| printf("cpu %d\n", cpu); | ||
| @xcnt = count(); | ||
| @xavg = avg(10 * cpu + 3); | ||
| @xstd = stddev(20 * cpu + 8); | ||
| @xmin = min(30 * cpu - 10); | ||
| @xmax = max(40 * cpu - 15); | ||
| @xsum = sum(50 * cpu); | ||
| } | ||
| tick-900ms | ||
| { | ||
| exit(0) | ||
| } | ||
| ' > dtrace.out | ||
| if [ $? -ne 0 ]; then | ||
| echo DTrace failed | ||
| cat dtrace.out | ||
| exit 1 | ||
| fi | ||
|
|
||
| # | ||
| # Examine the results. | ||
| # | ||
|
|
||
| awk ' | ||
| # The expected value for the aggregation is aggval. | ||
| # The expected value on a CPU is (m * cpu + b). | ||
| function check(label, aggval, m, b) { | ||
| # Check the aggregation over all CPUs. | ||
| getline; | ||
| print "check:", $0; | ||
| if ($1 != aggval) { printf("ERROR: %s, expect %d got %d\n", label, aggval, $1) }; | ||
| # Check the per-CPU values. | ||
| for (i = 1; i <= ncpu; i++) { | ||
| getline; | ||
| print "check:", $0; | ||
| if (match($0, "^ \\[CPU ") != 1 || | ||
| strtonum($2) != cpu[i] || | ||
| strtonum($3) != m * cpu[i] + b) | ||
| printf("ERROR: %s, agg per cpu %d, line: %s\n", label, cpu[i], $0); | ||
| } | ||
| } | ||
| BEGIN { | ||
| xcnt = xavg = xstm = xstd = xsum = 0; | ||
| xmin = +1000000000; | ||
| xmax = -1000000000; | ||
| ncpu = 0; | ||
| } | ||
| # The first "cpu" lines provide the inputs to the aggregations. | ||
| /^cpu [0-9]*$/ { | ||
| cpu[++ncpu] = strtonum($NF); | ||
| xcnt += 1; | ||
| x = 10 * $2 + 3; | ||
| xavg += x; | ||
| x = 20 * $2 + 8; | ||
| xstm += x; | ||
| xstd += x * x; | ||
| x = 30 * $2 - 10; | ||
| if (xmin > x) { xmin = x }; | ||
| x = 40 * $2 - 15; | ||
| if (xmax < x) { xmax = x }; | ||
| x = 50 * $2; | ||
| xsum += x; | ||
| next; | ||
| } | ||
| # The remaining lines are the aggregation results. | ||
| { | ||
| # First we finish computing our estimates for avg and stddev. | ||
| # (The other results require no further action.) | ||
| xavg /= xcnt; | ||
| xstm /= xcnt; | ||
| xstd /= xcnt; | ||
| xstd -= xstm * xstm; | ||
| xstd = int(sqrt(xstd)); | ||
| # Sort the cpus. | ||
| asort(cpu); | ||
| # Now read the results and compare. | ||
| check("cnt", xcnt, 0, 1); | ||
| check("avg", xavg, 10, 3); | ||
| check("std", xstd, 0, 0); | ||
| check("min", xmin, 30, -10); | ||
| check("max", xmax, 40, -15); | ||
| check("sum", xsum, 50, 0); | ||
| printf("done\n"); | ||
| } | ||
| ' dtrace.out > awk.out | ||
| if [ $? -ne 0 ]; then | ||
| echo awk failed | ||
| cat dtrace.out | ||
| exit 1 | ||
| fi | ||
|
|
||
| if grep -q ERROR awk.out ; then | ||
| echo ERROR found | ||
| echo "==================================================" | ||
| cat dtrace.out | ||
| echo "==================================================" | ||
| cat awk.out | ||
| echo "==================================================" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo success | ||
| exit 0 |