Skip to content

Commit

Permalink
pid: drop more Solaris-specific bug workarounds
Browse files Browse the repository at this point in the history
We definitely don't have any old binaries that exhibit a problem only
observed on old versions of Solaris lacking modern ELF constructors.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
  • Loading branch information
nickalcock authored and kvanhees committed Oct 25, 2022
1 parent 827e4e2 commit ef080b4
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions libdtrace/dt_pid.c
Original file line number Diff line number Diff line change
Expand Up @@ -272,16 +272,8 @@ dt_pid_sym_filt(void *arg, const GElf_Sym *symp, const char *func)
symp->st_value != pp->dpp_last.st_value ||
symp->st_size != pp->dpp_last.st_size) {
/*
* Due to 4524008, _init and _fini may have a bloated st_size.
* While this bug has been fixed for a while, old binaries
* may exist that still exhibit this problem. As a result, we
* don't match _init and _fini though we allow users to
* specify them explicitly.
* Versioned identifiers are a problem.
*/
if (strcmp(func, "_init") == 0 || strcmp(func, "_fini") == 0)
return 0;

/* Versioned identifiers are a problem. */
if (strchr(func, '@') != NULL)
return 0;

Expand Down

0 comments on commit ef080b4

Please sign in to comment.