-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better document relation with Factory10 interface and UnsupportedMessageException #191
Comments
Where does SL throw such an exception? @jtulach returning null is not a good idea - I think the JavaDoc of Factory10 is wrong. |
@grimmerm you can see throwing of these exception in the com.oracle.truffle.sl.runtime.SLxxxxMessageResolutionForeign classes. It's not clear that these are generated automatically -- nothing in the source indicate that, there's no @GeneratedBy or header comment telling so. |
Indeed, we should add a |
@grimmerm please fix this. |
Using |
…ruffle:fix_warnings to master * commit '514d19bc55be3b82f76b7b3cddfe27b34d245348': Fix warning: declared exception IOException is not actually thrown
There are currently no plans to fix this minor issue. |
The documentation for the Factory10 interface at the moment says that the accessXXX messages can return null if the message is not supported. However, example in SL shows that this is not done that way. Instead, the SL implementation always raise an UnsupportedMessageException (i.e., doing UnsupportedMessageException.raise(Message.XXX); )
Can you clarify in the documentation why is there two ways to do this and which one is the recommended one ?
The text was updated successfully, but these errors were encountered: