Inline methods that fold to a constant before the static analysis #2860

marjanasolajic · 2020-09-19T06:52:29Z

NativeImageInlineDuringParsingPlugin is a plugin that analyses the graph for the resolved Java method and specifies
what should be inlined during graph parsing before the static analysis. This plugin inlines methods that fold to a constant before the static analysis.

The native-image option for this plugin: -H:+InlineBeforeAnalysis.
The native-image option for inlining depth that is used in this plugin: -H:InlineBeforeAnalysisMaxDepth=value.
Default value for inlining depth is 9.

The performance impact of this plugin on analysis time and image size for benchmark suite renaissance is presented in the next documents.

graalvmbot · 2020-09-19T07:00:08Z

Hello Marjana Solajic, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address marjana -(dot)- s1010 -(at)- gmail -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

christianwimmer · 2020-09-21T17:22:04Z

...vm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/phases/AnalysisGraphBuilderPhase.java

@@ -88,5 +96,10 @@ protected boolean tryInvocationPlugin(InvokeKind invokeKind, ValueNode[] args, R
        public boolean canDeferPlugin(GeneratedInvocationPlugin plugin) {
            return plugin.getSource().equals(Fold.class) || plugin.getSource().equals(Node.NodeIntrinsic.class);
        }
+
+        @Override
+        protected Invoke createNonInlinedInvoke(ExceptionEdgeAction exceptionEdge, int invokeBci, CallTargetNode callTarget, JavaKind resultType) {


Seems like an unnecessary override. Same in HostedGraphBuilderPhase.

christianwimmer · 2020-09-21T17:29:58Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+
+    public static class Options {
+        @Option(help = "Inline methods which folds to constant during parsing before the static analysis.")//
+        public static final HostedOptionKey<Boolean> InlineBeforeAnalysis = new HostedOptionKey<>(false);


Why is it not enabled by default?

christianwimmer · 2020-09-21T17:35:59Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+     * After analysis we read information from this map to find inline decision we made using
+     * {@link #getResult}.
+     */
+    private static final ConcurrentHashMap<AnalysisMethod, ConcurrentHashMap<CallSite, InvocationResult>> dataInline = new ConcurrentHashMap<>();


We cannot use any static fields. Many image builds can run in the same VM, and no such state must survive a build. The standard solution is to put such information in an object registered in ImageSingletons

christianwimmer · 2020-09-21T17:37:03Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+
+    private static ConcurrentMap<CallSite, InvocationResult> callSitemap(ResolvedJavaMethod method) {
+        AnalysisMethod key;
+        if (method instanceof AnalysisMethod) {


There is toAnalysisMethod as a helper method for this

christianwimmer · 2020-09-21T17:40:19Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+    public static InvocationResult findResult(String methodName, String className) {
+        InvocationResult result = null;
+        for (Map.Entry<AnalysisMethod, ConcurrentHashMap<CallSite, InvocationResult>> pair : dataInline.entrySet()) {
+            if (pair.getKey().format("%n %H").equals(methodName + " " + className)) {


No, don't use string formatting to check for a nested name. Even in a method only used for testing.

removed, we can use now information from an object registered in ImageSingletons for tests

christianwimmer · 2020-09-21T17:40:42Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+                Collection<InvocationResult> results = pair.getValue().values();
+                /* in tests we call method only once */
+                assert results.size() == 1;
+                result = results.iterator().next();


What if methodName is not unique?

christianwimmer · 2020-09-21T17:46:07Z

.../src/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyDebugUsage.java

@@ -151,7 +151,8 @@ protected void verifyParameters(MethodCallTargetNode callTarget, StructuredGraph
                    "org.graalvm.compiler.core.test.VerifyDebugUsageTest$InvalidConcatDumpUsagePhase.run",
                    "org.graalvm.compiler.core.test.VerifyDebugUsageTest$InvalidDumpUsagePhase.run",
                    "org.graalvm.compiler.hotspot.SymbolicSnippetEncoder.verifySnippetEncodeDecode",
-                    "org.graalvm.compiler.truffle.compiler.phases.inlining.CallTree.dumpBasic"));
+                    "org.graalvm.compiler.truffle.compiler.phases.inlining.CallTree.dumpBasic",
+                    "com.oracle.svm.hosted.phases.TrivialMethodDetector.analyzeMethod"));


We certainly don't want to dump anything at level 1 when inlining during analysis. Maybe at level 2, could also be level 3.

christianwimmer · 2020-09-21T17:50:53Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+                /* Nothing to do, it's ok to read a static or instance field. */
+            } else if (node instanceof FrameState) {
+                /* Nothing to do */
+            } else if (node instanceof NewInstanceNode || node instanceof NewArrayNode || node instanceof CallTargetNode || node instanceof StoreFieldNode || node instanceof InvokeNode) {


The PR says "This plugin inlines methods which folds to a constant". So why allow CallTargetNode and StoreFieldNode here?

removed, for now, only left NewArrayNode because we need this for the #2500

christianwimmer · 2020-09-21T17:55:44Z

...com.oracle.svm.hosted/src/com/oracle/svm/hosted/snippets/IntrinsificationPluginRegistry.java

-         */
-        VMError.guarantee(previous == null, "Detected previously intrinsified element");
+        Object previous = analysisElements.putIfAbsent(new CallSiteDescriptor(method, bci), nonNullElement);
+        VMError.guarantee(previous == null || previous.equals(nonNullElement), "Newly intrinsified element (" + nonNullElement + ") different than the previous (" + previous + ")");


Using equals here to compare the previous and new element is dangerous. For example, for java.lang.reflect.Method two methods can be equals but still separate objects, which will lead to problems.

You must check for previous == nonNullElement here.

christianwimmer · 2020-09-21T17:57:29Z

substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/snippets/ReflectionPlugins.java

@@ -320,6 +321,9 @@ private static boolean processGetConstructor(GraphBuilderContext b, ResolvedJava
            /* We are analyzing the static initializers and should always intrinsify. */
            return element;
        }
+        if (((SharedGraphBuilderPhase.SharedBytecodeParser) context).getGraphBuilderConfig().getPlugins().getParameterPlugins().length > 0) {


What is this check doing? But relying on having a parameter plugin registered is most certainly wrong, because we cannot rely on a side effect like this.

cstancu

@marjanasolajic I reviewed your PR. Looks good, most of my comments refer to cosmetic changes. The only real question is the one related to the performance impact of this analysis and the fact that it looks like the analysis is repeated for a call site when that could be avoided.

cstancu · 2020-10-23T21:33:18Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+        }
+
+        if (callee.getAnnotation(NeverInline.class) != null || callee.getAnnotation(NeverInlineTrivial.class) != null || b.getMethod().getAnnotation(NeverInline.class) != null ||
+                        b.getMethod().getAnnotation(NeverInlineTrivial.class) != null) {


Does a @NeverInline annotation on a caller prevent inlining of any callees?

Removed for caller, that was a mistake, left only for a callee.

cstancu · 2020-10-23T21:45:58Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+        InvocationResult inline;
+
+        if (analysis) {
+            inline = ImageSingletons.lookup(NativeImageInlineDuringParsingPlugin.class).get(b.getMethod(), b.bci(), callee);


The ImageSingletons.lookup(...) line is identical in both branches you can pull it up: InvocationResult inline = ImageSingletons.lookup(...) and remove else branch.

cstancu · 2020-10-23T21:52:14Z

...tevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/phases/SharedGraphBuilderPhase.java

@@ -76,6 +76,8 @@ protected void run(StructuredGraph graph) {
        private final boolean explicitExceptionEdges;
        private final boolean allowIncompleteClassPath;

+        protected NativeImageInlineDuringParsingPlugin.InvocationResultInline inlineDuringParsingState;


Please document inlineDuringParsingState. It seems like it is used to store inline data for the currently parsed invoke.

Yes, that is its purpose. Added.

cstancu · 2020-10-23T21:53:27Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+    static final class CallSite {
+        final AnalysisMethod caller;
+        final int bci;
+        final AnalysisMethod callee;


Is the callee field needed? Doesn't seem to be used anywhere and it is excluded from the equality check.

You're right, I forgot to include this field in the check. Fixed.

cstancu · 2020-10-23T21:54:37Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+        }
+
+        @Override
+        public int hashCode() {


This method can be removed, implementation is identical with super method.

cstancu · 2020-10-23T22:22:34Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+            return InvocationResult.ANALYSIS_TOO_COMPLICATED;
+        }
+
+        MethodNodeTrackingAndInline methodState = new MethodNodeTrackingAndInline(new InvocationResultInline(callSite, method));


MethodNodeTrackingAndInline.result is not actually used in the class, it is just stored. Why not just allocate the InvocationResultInline below, in the return statement?

Actually, we use it to store decisions about children inlining.

cstancu · 2020-10-23T22:34:36Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+
+            CallSite callSite = new CallSite((AnalysisMethod) b.getMethod(), b.bci(), NativeImageInlineDuringParsingPlugin.toAnalysisMethod(callee));
+            InvocationResult state = analyzeMethod(callSite, (AnalysisMethod) callee, args);
+            ImageSingletons.lookup(NativeImageInlineDuringParsingPlugin.class).add(b.getMethod(), b.bci(), (AnalysisMethod) callee, state);


If this call site is reached by multiple call chains you run the analysis each time, then check if the results match. Wouldn't it be more efficient to run the analysis just once for each call site? What is the performance impact of this analysis on image build time?

Yes, you are right. Thanks for the advice. The way of method analysis is changed. We now remember the whole bci chain of calling context.

cstancu · 2020-10-23T22:45:30Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+     * We collect information during graph construction to filter non-trivial methods and inline
+     * trivial invokes. The result is used in {@link #analyzeMethod}.
+     */
+    class MethodNodeTrackingAndInline extends NodeEventListener implements InlineInvokePlugin {


I think this can be split into two classes one that extends NodeEventListener and one that implements InlineInvokePlugin, there is no shared state between the two so I think it is cleaner if they are separated, just like you do with the TrivialMethodDetectorParameterPlugin.

Done, thanks for the suggestion.

cstancu · 2020-10-23T22:47:05Z

.../org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/PEGraphDecoder.java

        for (InlineInvokePlugin plugin : inlineInvokePlugins) {
-            plugin.notifyAfterInline(inlineMethod);
+            if (notifyGraphBuilderContext == null) {
+                notifyGraphBuilderContext = new PENonAppendGraphBuilderContext(methodScope, invokeData.invoke);


notifyGraphBuilderContext can be initialized outside the loop. If you want to init it only when there are some inline plugins installed you can check the length of inlineInvokePlugins. Seems cleaner that way.

cstancu · 2020-10-23T22:49:44Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+        InvocationResult inline;
+
+        if (analysis) {
+            inline = ImageSingletons.lookup(NativeImageInlineDuringParsingPlugin.class).get(b.getMethod(), b.bci(), callee);


The ImageSingletons.lookup(NativeImageInlineDuringParsingPlugin.class) pattern repets several times. A NativeImageInlineDuringParsingPlugin.singleton() method that returns the value would improve readability.

Done, thanks for the suggestion.

christianwimmer · 2020-12-03T19:29:12Z

compiler/src/org.graalvm.compiler.java/src/org/graalvm/compiler/java/BciBlockMapping.java

@@ -350,6 +350,10 @@ public JSRData copy() {
            this.successors = new ArrayList<>();
        }

+        public boolean bciNotUnique() {


Style: avoid negated methods names, so name the method bciUnique

christianwimmer · 2020-12-03T19:34:03Z

compiler/src/org.graalvm.compiler.java/src/org/graalvm/compiler/java/BytecodeParser.java

@@ -3958,6 +3973,11 @@ public int bci() {
        return stream.currentBCI();
    }

+    @Override
+    public boolean hasBciDuplication() {


Style: method name here and in BlockMap should match

christianwimmer · 2020-12-03T19:35:46Z

substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/NativeImageGenerator.java

@@ -1134,6 +1139,11 @@ public static void registerGraphBuilderPlugins(FeatureHandler featureHandler, Ru
        SubstrateReplacements replacements = (SubstrateReplacements) providers.getReplacements();
        plugins.appendInlineInvokePlugin(replacements);

+        if (nativeImageInlineDuringParsingEnabled()) {
+            NativeImageInlineDuringParsingPlugin nativeImageInlineDuringParsingPlugin = new NativeImageInlineDuringParsingPlugin(analysis, providers);


Style: not having a local variable here actually makes the line shorter

christianwimmer · 2020-12-03T19:41:01Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+        return b.getCallingContext().stream().map(Pair::getLeft).anyMatch(caller -> caller.equals(callee));
+    }
+
+    private static boolean hasInvokeArgument(ValueNode[] args) {


Why does an invoke preclude inlining? That needs at least a good comment for documentation.

This is actually unnecessary because we will certainly not inline method if there is an invoke node in the graph. I removed this.

christianwimmer · 2020-12-03T19:42:27Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+
+    private static boolean hasInvokeArgument(ValueNode[] args) {
+        for (ValueNode arg : args) {
+            if (arg instanceof InvokeNode) {


InvokeNode is not general enough because there is also InvokeWithExceptionNode. You need to check for the interface Invoke to capture both.

I removed the whole method.

christianwimmer · 2020-12-03T19:46:16Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+        } catch (Throwable ex) {
+            debug.dump(DebugContext.VERBOSE_LEVEL, graph, "InlineDuringParsingAnalysis failed with %s", ex);
+            /*
+             * Whatever happens during the analysis is non-fatal because we can just not inline that


That is certainly a safe policy for production, but also hides stupid programming errors (like a NullPointerException somewhere in the analysis). So maybe not ignore exceptions when assertions are enabled in the image builder?

christianwimmer · 2020-12-03T19:55:16Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+                }
+            } else if (node instanceof StoreFieldNode) {
+                /*
+                 * We don't inline this method but go further in the analysis to check if any


I don't understand this handling of StoreFieldNode. Why "go further in the analysis" if in the end the result is "not inline"? analyzeGraph just returns false when this point was reached.

You are right, it is unnecessary to go further in the analysis in this case. I removed it.

vjovanov · 2020-12-04T23:27:17Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+            }
+
+            CallSite callSite = new CallSite(b.getCallingContext(), NativeImageInlineDuringParsingPlugin.toAnalysisMethod(callee));
+            InvocationResult inline = analyzeMethod(callSite, (AnalysisMethod) callee, args);


If we call here analyzeMethod, we can create infinite recursion. I don't think we should make a new graph in this case, but rather reuse only the analysis.

I added fix for this.

vjovanov · 2020-12-04T23:31:53Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+    }
+
+    private static boolean filterStringConcatGeneratedMethods(ResolvedJavaMethod method) {
+        return method.format("%H.%n").equals("java.lang.String.valueOf") || method.format("%H.%n").equals("java.lang.StringConcatHelper.prepend") ||


This kind of code is OK during testing, however, it is absolutely not OK in production due to style, performance, and correctness issues. This kind of code, makes people feel bad about the whole approach and the reviewer gets serious doubts about the credibility of the whole approach.

Yes, we cannot really merge that. But the proper fix should be really simple: while we are in a graph builder plugin (or any kind of intrinsic context), BytecodeParser.bciUnique needs to return false because any plugin can lead to more than one "replaced invoke" being produced.

I added fix for this and removed method filterStringConcatGeneratedMethods.

vjovanov · 2020-12-04T23:36:30Z

I am OK that this makes it into 21.0 as it is useful for experimenting with reflection, however:

The feature must be disabled by default and not announced publicly but only to interested parties.
The infinite recursion issue must be addressed before the feature freeze.
I would rename NativeImageInlineDuringParsingPlugin to ExperimentalNativeImageInlineDuringParsingPlugin and I would note in the comments that this code is for testing purposes only and that it will be replaced with a more elegant version.
The feature must pass all tests when enabled by default.

christianwimmer · 2020-12-05T00:02:43Z

...oracle.svm.hosted/src/com/oracle/svm/hosted/phases/NativeImageInlineDuringParsingPlugin.java

+
+    public static class Options {
+        @Option(help = "Inline methods which folds to constant during parsing before the static analysis.")//
+        public static final HostedOptionKey<Boolean> InlineBeforeAnalysis = new HostedOptionKey<>(true);


If we do not enable the option by default in this PR, then the option help text should start with "Experimental: "

graalvmbot · 2020-12-05T11:20:57Z

Hello marjanasolajic, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address 47460123+marjanasolajic -(at)- users -(dot)- noreply -(dot)- github -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

marjanasolajic force-pushed the plugin-inline-during-parsing branch 2 times, most recently from a42457f to 6a6bfbc Compare September 19, 2020 18:51

vjovanov requested a review from christianwimmer September 20, 2020 14:03

marjanasolajic mentioned this pull request Sep 21, 2020

Static methods do not allow code removal while static fields do #2594

Closed

vjovanov requested review from cstancu and vjovanov September 21, 2020 14:36

marjanasolajic changed the title ~~Inline During Parsing Plugin~~ Inline method that fold to a constant before analysis Sep 21, 2020

christianwimmer reviewed Sep 21, 2020

View reviewed changes

christianwimmer mentioned this pull request Sep 24, 2020

Feature: dynamic build-time interception of method calls (call-site analytics) #2368

Open

marjanasolajic force-pushed the plugin-inline-during-parsing branch 2 times, most recently from 76930fb to 4e4ee4a Compare September 26, 2020 13:41

marjanasolajic changed the title ~~Inline method that fold to a constant before analysis~~ Inline method that folds to a constant before analysis Sep 26, 2020

marjanasolajic force-pushed the plugin-inline-during-parsing branch 4 times, most recently from d5a8a6c to 7ee4c06 Compare October 2, 2020 20:24

marjanasolajic force-pushed the plugin-inline-during-parsing branch from 7ee4c06 to c23b20f Compare October 7, 2020 11:51

marjanasolajic force-pushed the plugin-inline-during-parsing branch 8 times, most recently from b993cad to 71da1a3 Compare October 23, 2020 14:44

cstancu reviewed Oct 23, 2020

View reviewed changes

marjanasolajic force-pushed the plugin-inline-during-parsing branch 3 times, most recently from 78c43cc to 9b79049 Compare October 24, 2020 21:39

marjanasolajic force-pushed the plugin-inline-during-parsing branch 2 times, most recently from c244a65 to a3beed2 Compare November 30, 2020 09:08

vjovanov force-pushed the plugin-inline-during-parsing branch from a3beed2 to 38e0026 Compare November 30, 2020 12:30

marjanasolajic force-pushed the plugin-inline-during-parsing branch 7 times, most recently from e7aa891 to 47baf31 Compare December 3, 2020 13:00

vjovanov force-pushed the plugin-inline-during-parsing branch from 47baf31 to e57c1e4 Compare December 3, 2020 15:48

vjovanov changed the title ~~Inline method that folds to a constant before analysis~~ Inline methods that folds to a constant before analysis Dec 3, 2020

christianwimmer requested changes Dec 3, 2020

View reviewed changes

marjanasolajic force-pushed the plugin-inline-during-parsing branch from cbd4ea0 to 02a2c3d Compare December 4, 2020 14:45

vjovanov reviewed Dec 4, 2020

View reviewed changes

vjovanov self-assigned this Dec 4, 2020

vjovanov added native-image feature labels Dec 4, 2020

vjovanov added this to To do in Native Image via automation Dec 4, 2020

christianwimmer reviewed Dec 5, 2020

View reviewed changes

marjanasolajic force-pushed the plugin-inline-during-parsing branch from d60f733 to d2cde83 Compare December 5, 2020 11:33

marjanasolajic changed the title ~~Inline methods that folds to a constant before analysis~~ Inline methods that fold to a constant before the static analysis Dec 6, 2020

marjanasolajic force-pushed the plugin-inline-during-parsing branch 2 times, most recently from 35828cd to 2ecab68 Compare December 6, 2020 16:55

marjanasolajic closed this Dec 7, 2020

marjanasolajic force-pushed the plugin-inline-during-parsing branch from d270edb to cc1b020 Compare December 7, 2020 11:26

Native Image automation moved this from To do to Done Dec 7, 2020

Inline methods that fold to a constant before the static analysis #2860

Inline methods that fold to a constant before the static analysis #2860

Conversation

marjanasolajic commented Sep 19, 2020 • edited

graalvmbot commented Sep 19, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marjanasolajic Oct 2, 2020 • edited

Choose a reason for hiding this comment

cstancu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vjovanov commented Dec 4, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

graalvmbot commented Dec 5, 2020

marjanasolajic commented Sep 19, 2020 •

edited

marjanasolajic Oct 2, 2020 •

edited

vjovanov commented Dec 4, 2020 •

edited