[GR-47449] Verify return types of substituted methods #7340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
zapster
reviewed
Sep 5, 2023
| @@ -375,6 +375,7 @@ def extra_image_build_argument(self, benchmark, args): | |||
| '-H:+AllowFoldMethods', | |||
| '-H:-UseServiceLoaderFeature', | |||
| '-H:+AllowDeprecatedBuilderClassesOnImageClasspath', # needs to be removed once GR-41746 is fixed | |||
| '-H:+DisableSubstitutionReturnTypeCheck', # remove once Quarkus fixed their substitutions (GR-48152) | |||
There was a problem hiding this comment.
@zakkak I had to add this for our Quarkus jobs because in the (quite old) version we are using there were substitutions with return type mismatches. The offending substitution seems to be gone on master, but I have not checked all the others. Maybe things are fine, maybe not. Just a heads up. :)
There was a problem hiding this comment.
Hi @zapster, thanks for the heads up.
It looks like there are some failures on Quarkus main as well which I am working on in quarkusio/quarkus#35847 and quarkusio/quarkus#35956
graalvmbot
force-pushed
the
je/svm-check-substitution-return-type-GR-47449
branch
from
fa39f59
to
bcf1261
Compare
graalvmbot
deleted the
je/svm-check-substitution-return-type-GR-47449
branch
zakkak
added a commit
to zakkak/quarkus
that referenced
this pull request
Sep 11, 2023
Resolves issues with new strict checking introduced with oracle/graal#7340
zakkak
added a commit
to zakkak/quarkus
that referenced
this pull request
Sep 12, 2023
Resolves issues with new strict checking introduced with oracle/graal#7340
franz1981
pushed a commit
to franz1981/quarkus
that referenced
this pull request
Sep 13, 2023
Resolves issues with new strict checking introduced with oracle/graal#7340
holly-cummins
pushed a commit
to holly-cummins/quarkus
that referenced
this pull request
Feb 8, 2024
Resolves issues with new strict checking introduced with oracle/graal#7340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return types of substitution methods must match the return type of the target method. Incompatible types can lead to failures in the compiled code, e.g., unexpected
NullPointerException, which are hard to debug. Note that none of the changed substitutions suffered from these problems because although there were mismatches, the specified types were usually a super type of the target return types (e.g.Objectinstead of the concrete type). Still, this verification helps catching problems in new substitutions early.