Add "addSubShift" rule for AArch64.

[XiaohongGong]

No description provided.

[graalvmbot]

Hello Xiaohong Gong, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address xiaohong -(dot)- gong -(at)- arm -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

[XiaohongGong]

Hi, I'm an employee from Arm and I have signed the OCA. Can you please check and add my email to the oca list? Thank you!

[graalvmbot]

Xiaohong Gong has signed the Oracle Contributor Agreement (based on email address xiaohong -(dot)- gong -(at)- arm -(dot)- com) so can contribute to this repository.

[XiaohongGong]

Hi all,
I have added a new match rule for AArch64, which will combine the add/sub and shift instructions to one add(shift)/sub(shift) instruction. Could anyone please take a review to my patch? Thank you!

[XiaohongGong]

@sanzinger could you take a look at this patch? Thank you!

[sanzinger]

Thank you for your contribution. Overall this PR looks good. See my remarks inline.

[XiaohongGong]

@sanzinger I have resolved the comments except for the copyright, and the new patch is updated. Can you please take a look at it? Thank you!

[XiaohongGong]

@sanzinger Is there any conclusion about the correct copyright? I'm a little worried because there will be many optimizing PRs afterwards which all depends on this patch. This patch contains the basic match rule tests for AArch64. Waiting for your answer. Thank you!

[dougxc]

Hi @XiaohongGong , sorry for the delay. We're trying to reach a conclusion as quickly as possible.

[XiaohongGong]

@dougxc Thank you so much!

[sanzinger]

We can keep the copyright header. I'm going to integrate this change.

[XiaohongGong]

@sanzinger thank you so much!

[XiaohongGong]

Hi @sanzinger, thanks for your reviewing. But is there any problems exist when integrating this change? I mean whether the merging job is conflict or any other else problems exist that need my help. Thank you!

[graalvmbot]

Hello XiaohongGong, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address 44149651+xiaohonggong -(at)- users -(dot)- noreply -(dot)- github -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

[XiaohongGong]

Hi @sanzinger , I have checked the latest codes in the master branch, but I have found that it is not the latest for this patch. The patch merged is the one I first committed. The newest version includes some fixed codes according to your comment. And I think they are all valuable. Is there any method to revert this merging and merge the right version? If not, I will commit a new patch which will include all these changes. Thank you!

[XiaohongGong]

Hi @sanzinger , I have committed another path #781 which is a part of this patch. Could you please take a look at it? Thank you!

[sanzinger]

Thank you for your contributions. It seems that merged PR #781 contains all changes from this PR. Hence closing.