[GR-50773] Improve typing of GraphProvider and signatures. #7982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
ParseOnce
is the only execution mode, andResolvedSignature
can provide better typing for signatures, this PR improves typing and removes explicit type checks.GraphProvider.buildGraph
, pass inAnalysisMethod
to remove later explicit casts.SubstrateGraphKit.loadArguments
. It is just silly to load arguments based on the method signature (which could be the wrong signature), we can just collect the arguments when theFrameStateBuilder
creates them.AnalysisMethod.getSignature
andHostedMethod.getSignature
and remove later explicit casts.getParameterType
andgetReturnType
methods ofResolvedSignature
that do not need anaccessingClass
parameter.ResolvedSignature.toParameterList
where appropriate and remove later explicit casts.SimpleSignature
withResolvedSignature
ResolvedJavaMethod.toParameterTypes
because it is badly defined for constructors. Overrides inAnalysisMethod
andHostedMethod
prevent future usage in our universe.